appleremote02 (part6)
Time for code review, last step for the cws before to be ready for QA.Philipp Lohmann agreed the changes in vcl ( and thus, the corresponding changes in apple_remote module)
Several problems had to be 直す/買収する,八百長をするd :
* Christian Lippka 示唆するd the use of MEDIA_COMMAND_VOLUME (UP and DOWN ) had to be changed, for other OS than Mac OS S X [直す/買収する,八百長をするd]
* 保護する the popup menu 事例/患者 [直す/買収する,八百長をするd]
* Andre Fischer asked about the eventlistener [部分的に/不公平に 直す/買収する,八百長をするd]: is not 正確に/まさに at the 権利 place, because I 追加する the eventlistener at the end of GetState(SfxItemSet&) method, and this would result in 多重の calls to 使用/適用::AddEventListener(const Link&). The 使用/適用 class 蓄える/店s event listeners in a 名簿(に載せる)/表(にあげる), not in a 始める,決める, and thus, more than one eventlistener may be 登録(する)d for a 選び出す/独身 SdModule 反対する. Fortunaly, when the (one) listener is 除去するd in ~SdModule the 使用/適用::RemoveEventListener(const Link&) 除去するs all listeners (that's what I 立証するd using 漏れるs on Mac)
The possible 解答s :
追加する the listener 直接/まっすぐに in the SdModule Ctor : Does not work (maybe my fault), because this leads to a sort of chicken-egg problem, and after some 実験(する)s, it seems to be unbuildable ( I gve up with that).
Philipp 提案するd a 解答 I 実験(する)d already, based on a singleton pattern [done, 作品 already]
調査/捜査するing on another more 複雑にするd, but elegant 解答 Andre 提案するd. the idea is to create a static Create() method for SdModule, that creates and initializes an SdModule 反対する.
This needs to make the 建設者 私的な (no 味方する 影響s ?) and finally to have SdDLL::Init() calling this new Create() method. Work in 進歩 ...
A big thank you for the code review, and for the time they spend helping me to Andre Fischer,Christian Lippka, Philipp Lohmann and Thorsten Behrens ( kindly answering my questions on the #education.openof fice.org channel)
Libell?s : Apple, 開発, High-Tech, Mac OS X, Teaching OpenSource



